[webkit-reviews] review denied: [Bug 88334] Prefer higher specificity selectors for rule set keys : [Attachment 146602] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at webkit.org> has denied Joshua Peek
<josh at joshpeek.com>'s request for review:
Bug 88334: Prefer higher specificity selectors for rule set keys
https://bugs.webkit.org/show_bug.cgi?id=88334

Attachment 146602: Patch
https://bugs.webkit.org/attachment.cgi?id=146602&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146602&action=review


> Source/WebCore/css/CSSParserValues.cpp:118
> +bool CSSParserSelector::hasPseudoElement()
> +{
> +  CSSParserSelector* selector = this;
> +  while (selector) {
> +    if (selector->m_selector->matchesPseudoElement())
> +	 return true;
> +    selector = selector->tagHistory();
> +  }
> +  return false;
> +}

WebKit coding style is to use 4 spaces for indentation, not 2.

I think this could be written a little more clearly as a for loop.

Do we need to worry about the performance implications of this extra loop?