[webkit-reviews] review requested: [Bug 88668] [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized : [Attachment 146603] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 10:46:33 PDT 2012


vollick at chromium.org has asked	for review:
Bug 88668: [chromium] Single thread proxy's animation timer should short
circuit if the layer renderer has not been initialized
https://bugs.webkit.org/show_bug.cgi?id=88668

Attachment 146603: Patch
https://bugs.webkit.org/attachment.cgi?id=146603&action=review

------- Additional Comments from vollick at chromium.org
This ended up being a 2 line change, but the testing required some more work.
Rather than adding yet more tests to CCLayerTreeHostTest that don't belong
there, I refactored the code required for running threaded tests into
CCThreadedTest.h/cpp, added a CCSingleThreadProxyTest.cpp and moved the proxy-
related tests into that file. This will allow us to more easily create new
tests
that require simulating the threaded environment.


More information about the webkit-reviews mailing list