[webkit-reviews] review granted: [Bug 88596] [chromium/mac] Improve deviceDPI, rect, and availableRect computation : [Attachment 146428] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 7 17:41:35 PDT 2012
Adam Barth <abarth at webkit.org> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 88596: [chromium/mac] Improve deviceDPI, rect, and availableRect
computation
https://bugs.webkit.org/show_bug.cgi?id=88596
Attachment 146428: Patch
https://bugs.webkit.org/attachment.cgi?id=146428&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146428&action=review
This looks reasonable to me, but you might want to wait for input from fsamuel.
> Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm:65
> + if (window)
> + {
Is this proper style? I'm not familiar with the style for .mm files.
More information about the webkit-reviews
mailing list