[webkit-reviews] review requested: [Bug 88596] [chromium/mac] Improve deviceDPI, rect, and availableRect computation : [Attachment 146428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 17:42:05 PDT 2012


Nico Weber <thakis at chromium.org> has asked  for review:
Bug 88596: [chromium/mac] Improve deviceDPI, rect, and availableRect
computation
https://bugs.webkit.org/show_bug.cgi?id=88596

Attachment 146428: Patch
https://bugs.webkit.org/attachment.cgi?id=146428&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146428&action=review


>> Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm:87
>> +	float deviceDPI = 160 * deviceScaleFactor(view);
> 
> We have this 160 constant in ViewportArguments.cpp.  Should we move it to a
header where it can be shared?

I don't know. Basing anything off DPI seems silly to me, but then again I don't
do mobile stuff. (Does mobile have useful, real DPI data? I'm not sure why it
would be less fake than on desktop though.)

This is already duplicated in render_widget.cc. I think longer term it's better
to get rid of the DPI stuff, especially if we remove that from the viewport tag
like you hinted at on webkit-dev.


More information about the webkit-reviews mailing list