[webkit-reviews] review granted: [Bug 88581] webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question : [Attachment 146399] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 88581: webkit-patch rebaseline-expectations should only rebaseline the
appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Attachment 146399: Patch
https://bugs.webkit.org/attachment.cgi?id=146399&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146399&action=review


Thanks for the quick fix!

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:88
> +# FIXME: Perhas these two routines should be part of the Port instead?

s/Perhas/Perhaps. I doubt these will end up being port-specific. The platform
identifies might though. Either way, no harm in having a FIXME.

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:289
> +	       self._run_webkit_patch(['rebaseline-test', '--suffixes',
','.join(suffixes), builder_name, test_name])

Maybe add a FIXME to use run_in_parallel here?