[webkit-reviews] review denied: [Bug 88028] [chromium] Provide access to the WebPlugin created by the helper plugin widget : [Attachment 146173] Use getElementsByTagName() to get the WebPlugin

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 88028: [chromium] Provide access to the WebPlugin created by the helper
plugin widget
https://bugs.webkit.org/show_bug.cgi?id=88028

Attachment 146173: Use getElementsByTagName() to get the WebPlugin
https://bugs.webkit.org/attachment.cgi?id=146173&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146173&action=review


>> Source/WebKit/chromium/public/WebPlugin.h:143
>> +	virtual bool isPpapi() { return false; }
> 
> I'm not 100% sure if this function is correct.  My understand was that WebKit
should be ignorant of PPAPI.

This is definitely wrong.  I see no callers of this function, why are you
adding it?