[webkit-reviews] review requested: [Bug 34608] Deleting text leaves the style of text in the typing style : [Attachment 146379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 13:54:24 PDT 2012


Pravin D <pravind.2k4 at gmail.com> has asked  for review:
Bug 34608: Deleting text leaves the style of text in the typing style
https://bugs.webkit.org/show_bug.cgi?id=34608

Attachment 146379: Patch
https://bugs.webkit.org/attachment.cgi?id=146379&action=review

------- Additional Comments from Pravin D <pravind.2k4 at gmail.com>
When a node is deleted the associated style is not completely deleted in 
saveTypingStyleState(). 

saveTypingStyleState() only deletes the style the enclosing Anchor node(node
with a link). In case there is no enclosing anchor node, the typing style is
not updated properly.  

In the patch the style associated with the node is deleted only when the node
is completely removed. Not sure if it is the correct location.
Will add more test case once am sure of the patch.


More information about the webkit-reviews mailing list