[webkit-reviews] review denied: [Bug 82692] -webkit-user-select: none makes text fields not editable : [Attachment 146279] patch 1

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 82692: -webkit-user-select: none makes text fields not editable
https://bugs.webkit.org/show_bug.cgi?id=82692

Attachment 146279: patch 1
https://bugs.webkit.org/attachment.cgi?id=146279&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146279&action=review


> Source/WebCore/dom/Position.cpp:852
> -    return node && node->renderer() &&
node->renderer()->style()->userSelect() == SELECT_NONE;
> +    return node && node->renderer() &&
node->renderer()->style()->userSelect() == SELECT_NONE && node->isShadowRoot();


This is not the right fix. We need to update the style resolution code instead.

Otherwise, -webkit-user-select: none would never work inside shadow DOM.