[webkit-reviews] review granted: [Bug 88456] get rebaselining tools to kinda work with the skia overrides file : [Attachment 146130] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 15:40:48 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 88456: get rebaselining tools to kinda work with the skia overrides file
https://bugs.webkit.org/show_bug.cgi?id=88456

Attachment 146130: Patch
https://bugs.webkit.org/attachment.cgi?id=146130&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146130&action=review


> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:264
> +    def _expectations(self, port, include_overrides):
> +	   return TestExpectations(port, include_overrides=include_overrides)

Do we really need this method still?


More information about the webkit-reviews mailing list