[webkit-reviews] review granted: [Bug 88430] Element.getBoudingClientRect() and Element.getClientRects() return incorrect values in frames in a scaled page : [Attachment 146098] patch v3 (using Frame::frameScaleFactor())

Wed Jun 6 15:39:45 PDT 2012

James Robinson <jamesr at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 88430: Element.getBoudingClientRect() and Element.getClientRects() return
incorrect values in frames in a scaled page
https://bugs.webkit.org/show_bug.cgi?id=88430

Attachment 146098: patch v3 (using Frame::frameScaleFactor())
https://bugs.webkit.org/attachment.cgi?id=146098&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146098&action=review


R=me

> Source/WebCore/ChangeLog:3
> +	   Element.getBoudingClientRect() and Element.getClientRects() return
incorrect values in frames in a scaled page

typo "bouding" -> "bounding"

> Source/WebCore/dom/Document.cpp:6041
> +

extra newline

> LayoutTests/fast/dom/Element/scale-page-bounding-client-rect-in-frame.html:1
> +<html>

please use <!DOCTYPE html> for this and other new test files unless you
explicitly want to test quirks mode behavior