[webkit-reviews] review denied: [Bug 88222] Improve the performance of pushScope in StyleResolver : [Attachment 145558] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 88222: Improve the performance of pushScope in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=88222

Attachment 145558: Patch
https://bugs.webkit.org/attachment.cgi?id=145558&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145558&action=review


> Source/WebCore/ChangeLog:10
> +	   Reviewed by NOBODY (OOPS!).

The "Reviewed By" line should be jut after the bug URL. See others.

> Source/WebCore/css/StyleResolver.cpp:563
>      for (; parent; parent = parent->parentOrHostNode()) {

It would be better to introduce new local variable for this loop instead of
reusing the parameter.
It's generally a bad style to reuse it and that is a source of this bug.

> Source/WebCore/css/StyleResolver.cpp:597
> +	       const ScopeStackFrame& lastFrame =
m_scopeStack[m_scopeStack.size() - 1];

Vector::last() is preferred. Then it's easy to pack the conditional into the
single if clause.
Also, why do we need isEmpty() check?