[webkit-reviews] review granted: [Bug 86885] CSS 2.1 failure: border-conflict-element-021a : [Attachment 145552] Patch

Mon Jun 4 18:10:26 PDT 2012

Julien Chaffraix <jchaffraix at webkit.org> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 86885: CSS 2.1 failure: border-conflict-element-021a
https://bugs.webkit.org/show_bug.cgi?id=86885

Attachment 145552: Patch
https://bugs.webkit.org/attachment.cgi?id=145552&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145552&action=review

Thanks for fixing all the issues. r=me with one comment and one nit. Btw, if
you want your patch to be landed make sure you check the cq? flag as part of
your change (under webkit-patch, you can use --request-commit).

> Source/WebCore/rendering/RenderTable.cpp:1119
> +    if (m_foot)
> +	   return m_foot;

I am still surprised at that working but thanks the new test is passing so it
must be me.

> Source/WebCore/rendering/RenderTable.h:195
> +    RenderTableSection* bottomSection() const;

This should go next to the topSection() getter.

> LayoutTests/fast/table/border-collapsing/adjacent-row-groups-expected.html:4
> +
> +<html>
> +

Nit: I really don't think this spaces add much. Not repeated on the other
files.