[webkit-reviews] review denied: [Bug 87821] [Chromium] Compositor doesn't support translucent root layers. : [Attachment 145368] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 87821: [Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821

Attachment 145368: Patch
https://bugs.webkit.org/attachment.cgi?id=145368&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145368&action=review


Code looks reasonable but it could be much simpler.

This also needs tests of some form.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:396
> +    if (renderSurface != rootRenderSurface || !settings().opaqueRootLayer)

This is weird as a setting - why not just check if the root layer is opaque
directly?

> Source/WebKit/chromium/public/WebSettings.h:158
> +    virtual void setOpaqueRootLayer(bool) = 0;

I don't think it makes sense for WebSettings to be talking about the root
layer.	This is really about whether the WebView may be rendered translucently,
right?

What's supposed to happen when this view isn't composited?