[webkit-reviews] review denied: [Bug 88179] Hit ASSERT when editing attribute value in Element in SVG Document : [Attachment 145617] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 12:44:59 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 88179: Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Attachment 145617: Patch
https://bugs.webkit.org/attachment.cgi?id=145617&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145617&action=review


> LayoutTests/inspector/elements/set-attribute-non-html.svg:104
> +	       targetNode.setAttribute("foo", "foo2='baz2' foo3='baz3'");

You only want this test case to test your chanthis 

Btw, this patch is missing the expectations file, r- for this.


More information about the webkit-reviews mailing list