[webkit-reviews] review canceled: [Bug 88065] [BlackBerry] IndexedDB file should be sand-boxed to the application data directory. : [Attachment 145247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 08:22:20 PDT 2012


Charles Wei <charles.wei at torchmobile.com.cn> has canceled Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 88065: [BlackBerry] IndexedDB file should be sand-boxed to the application
data directory.
https://bugs.webkit.org/show_bug.cgi?id=88065

Attachment 145247: Patch
https://bugs.webkit.org/attachment.cgi?id=145247&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
View in context: https://bugs.webkit.org/attachment.cgi?id=145247&action=review


>> Source/WebCore/Modules/indexeddb/IDBFactory.cpp:102
>> +	    m_backend->open(name, request.get(), context->securityOrigin(),
frame,
String(BlackBerry::Platform::Client::get()->getApplicationDataDirectory().c_str
()));
> 
> Is it possible to put get dataDir in a port specific section? So if dataDir
is empty we call
BlackBerry::Platform::Client::get()->getApplicationDataDirectory()? Or is there
nothing port specific?

Yes, we should make that at a port specific section. I'll try with another
patch. Thanks.


More information about the webkit-reviews mailing list