[webkit-reviews] review granted: [Bug 88063] Cleanup GeneratorGeneratedImage/Gradient changes from http://trac.webkit.org/changeset/117858 : [Attachment 145238] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 88063: Cleanup GeneratorGeneratedImage/Gradient changes from
http://trac.webkit.org/changeset/117858
https://bugs.webkit.org/show_bug.cgi?id=88063

Attachment 145238: patch
https://bugs.webkit.org/attachment.cgi?id=145238&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145238&action=review


> Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:65
>  
> -    if (!m_cachedImageBuffer
> -	   || m_cachedGeneratorHash != generatorHash
> -	   || m_cachedAdjustedSize != adjustedSize
> -	   || !destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get()))
{
> -	   // Create a BitmapImage and call drawPattern on it.
> +    if (!m_cachedImageBuffer || m_cachedGeneratorHash != generatorHash ||
m_cachedAdjustedSize != adjustedSize ||
!destContext->isCompatibleWithBuffer(m_cachedImageBuffer.get())) {

If the patch to draw() has been checked in by now, that will need the same
cleanup.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:767
> +    if (a.xScale() != b.xScale() || a.yScale() != b.yScale())
> +	   return false;

return a.xScale() == b.xScale() && a.yScale() == b.yScale()?