[webkit-reviews] review requested: [Bug 92725] IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type : [Attachment 155461] Patch

[bugzilla-daemon at webkit.org]

Joshua Bell <jsbell at chromium.org> has asked  for review:
Bug 92725: IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte
type
https://bugs.webkit.org/show_bug.cgi?id=92725

Attachment 155461: Patch
https://bugs.webkit.org/attachment.cgi?id=155461&action=review

------- Additional Comments from Joshua Bell <jsbell at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155461&action=review


You're right - the range of existing values that are used for the
ObjectMetaDataType should encode identically for VarInt and Byte since they are
<= 127. So this should be safe. (A webkit_unit_test case could be added for
that, validating that the encodings are the same for the current roster of
values.) Removing my paranoid objection.

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:67
> +//	  The prefix is followed by a type byte, then a variable-length
integer, and then another variable-length integer.

That should end with "and then another type byte."