[webkit-reviews] review denied: [Bug 92819] MarkedAllocator::tryAllocateHelper() should sweep another block if it can't sweep a Structure block : [Attachment 155698] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 92819: MarkedAllocator::tryAllocateHelper() should sweep another block if
it can't sweep a Structure block
https://bugs.webkit.org/show_bug.cgi?id=92819

Attachment 155698: Patch
https://bugs.webkit.org/attachment.cgi?id=155698&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=155698&action=review


Looks good but I think I see a bug.

> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:92
> +    while (m_currentBlockToSweepIndex < m_blocksToSweep.size()) {

I don't think you want this loop here, do you? The goal of this function is to
sweep just one.

> Source/JavaScriptCore/heap/MarkedAllocator.cpp:38
> +	       m_heap->sweeper()->sweepNextBlock();

This could use a "why" comment.