[webkit-reviews] review denied: [Bug 92553] Add ENABLE_CSS_COMPOSITING flag : [Attachment 155103] remove all OOPS + set flag to 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 27 20:15:04 PDT 2012


Dirk Schulze <krit at webkit.org> has denied  review:
Bug 92553: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Attachment 155103: remove all OOPS + set flag to 0
https://bugs.webkit.org/attachment.cgi?id=155103&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
You should not only remove the OOPS lines, but also add a comment what the
change is about. I gave an example in my previous review: "Adds compiler flag
CSS_COMPOSITING to build systems to enable CSS blending and compositing. See
spec ...." See also http://www.webkit.org/coding/contributing.html for
guidelines how to contribute patches. I still would like to see the flag added
in other make files as well. Later it might be required to describe on every
function listed in the ChangeLog what the change is about.


More information about the webkit-reviews mailing list