[webkit-reviews] review denied: [Bug 92553] Add ENABLE_CSS_COMPOSITING flag : [Attachment 155104] added descriptions

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied  review:
Bug 92553: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553

Attachment 155104: added descriptions
https://bugs.webkit.org/attachment.cgi?id=155104&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=155104&action=review


I would still like to see more makefiles edited. At least CMAKE GNUmakefile and
the chromium make file (together with the already edited files, these should
cover all build systems anyway).

> Source/JavaScriptCore/ChangeLog:9
> +	   Add ENABLE_CSS_COMPOSITING flag
> +	   https://bugs.webkit.org/show_bug.cgi?id=92553
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Configurations/FeatureDefines.xcconfig: 
> +	   Adds compiler flag CSS_COMPOSITING to build systems to enable CSS
blending and compositing. See spec
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

The change log should look like this:

2012-07-27  Rik Cabanier  <cabanier at adobe.com>

	Add ENABLE_CSS_COMPOSITING flag
	https://bugs.webkit.org/show_bug.cgi?id=92553

	Reviewed by NOBODY (OOPS!).

	Adds compiler flag CSS_COMPOSITING to build systems to enable CSS
blending and compositing. See spec
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html

	* Configurations/FeatureDefines.xcconfig: 

The link that I posted before say how a ChangeLog should look like. And they
also say "Use this to write up a brief summary of the changes you've made". You
can also find a link with an example of a ChangeLog entry. The lines that you
removed usually guide you as well and say what you should do.