[webkit-reviews] review granted: [Bug 92367] Move region from HitTestResult to HitTestPoint : [Attachment 154610] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 92367: Move region from HitTestResult to HitTestPoint
https://bugs.webkit.org/show_bug.cgi?id=92367

Attachment 154610: Patch
https://bugs.webkit.org/attachment.cgi?id=154610&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154610&action=review


r=me

> Source/WebCore/rendering/HitTestResult.cpp:107
> +HitTestPoint::HitTestPoint(const HitTestPoint& other, const LayoutSize&
offset, RenderRegion* region)
> +    : m_point(other.m_point)
> +    , m_boundingBox(other.m_boundingBox)
> +    , m_transformedPoint(other.m_transformedPoint)
> +    , m_transformedRect(other.m_transformedRect)
> +    , m_region(region)

I wonder who owns this point. Can it be deleted elsewhere, and we get garbage
here?