[webkit-reviews] review denied: [Bug 92380] Extend Dictionary with support for accessing an array of Dictionaries. : [Attachment 154647] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 92380: Extend Dictionary with support for accessing an array of
Dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=92380

Attachment 154647: Patch
https://bugs.webkit.org/attachment.cgi?id=154647&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154647&action=review


r- due to missing tests.

> Source/WebCore/ChangeLog:10
> +	   isn't reasible so I have added two new methods: getArrayLength and
getArrayItem.

I don't understand why you need these two methods. Please describe your working
context here.

> Source/WebCore/ChangeLog:12
> +	   No new tests (OOPS!).

Please add test cases not only to test your change but also to show how you are
planning to use the methods.

> I would be grateful if someone could describe how to add tests for the class
Dictionary.

There are no unit tests. You can add LayoutTests that use the methods.