[webkit-reviews] review granted: [Bug 91707] Implement the experimental Content Security Policy script interface. : [Attachment 153592] XCode is happy. I think.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 26 00:32:49 PDT 2012
Adam Barth <abarth at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 91707: Implement the experimental Content Security Policy script interface.
https://bugs.webkit.org/show_bug.cgi?id=91707
Attachment 153592: XCode is happy. I think.
https://bugs.webkit.org/attachment.cgi?id=153592&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153592&action=review
> Source/WebCore/page/DOMSecurityPolicy.cpp:37
> +
extra blank line here.
> Source/WebCore/page/DOMSecurityPolicy.h:63
> + bool allowsConnectionTo(String url) const;
> + bool allowsFontFrom(String url) const;
> + bool allowsFrameFrom(String url) const;
> + bool allowsImageFrom(String url) const;
> + bool allowsMediaFrom(String url) const;
> + bool allowsObjectFrom(String url) const;
> + bool allowsScriptFrom(String url) const;
> + bool allowsStyleFrom(String url) const;
These should all be const String&
> Source/WebCore/page/DOMSecurityPolicy.idl:30
> + InterfaceName=securityPolicy
securityPolicy -> SecurityPolicy
More information about the webkit-reviews
mailing list