[webkit-reviews] review denied: [Bug 92334] Add WTF:currentLocalTimeMS() : [Attachment 154560] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 26 00:36:07 PDT 2012


Kent Tamura <tkent at chromium.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 92334: Add WTF:currentLocalTimeMS()
https://bugs.webkit.org/show_bug.cgi?id=92334

Attachment 154560: Patch
https://bugs.webkit.org/attachment.cgi?id=154560&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154560&action=review


> Source/WTF/wtf/CurrentTime.h:50
> +WTF_EXPORT_PRIVATE double currentLocalTimeMS();

What this function returns is unclear, and I think it's hard to explain what
this is briefly.

I recommend not to make a function for these five lines, but to make a function
to get timezone offset in milliseconds.  It would be a function named
"timezoneOffsetMSFor()".


More information about the webkit-reviews mailing list