[webkit-reviews] review granted: [Bug 91885] [chromium] Move WebFilterOperations from RenderPassDrawQuad to RenderPass : [Attachment 154100] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 91885: [chromium] Move WebFilterOperations from RenderPassDrawQuad to
RenderPass
https://bugs.webkit.org/show_bug.cgi?id=91885

Attachment 154100: Patch
https://bugs.webkit.org/attachment.cgi?id=154100&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154100&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:383
> +    m_renderPassesById = &renderPassesById;

Thanks, that's way better.  Theoretically, if you wanted I suppose you could
get rid of both m_defaultRenderPass and m_renderPassesById by passing them
through drawRenderPass/drawQuad like rootScissorRectInCurrentSurface is.  It's
not necessary, but just a thought.