[webkit-reviews] review denied: [Bug 88638] [Qt] requestAnimationFrame should only trigger when a new frame can be displayed. : [Attachment 154054] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 10:49:21 PDT 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 88638: [Qt] requestAnimationFrame should only trigger when a new frame can
be displayed.
https://bugs.webkit.org/show_bug.cgi?id=88638

Attachment 154054: patch for review.
https://bugs.webkit.org/attachment.cgi?id=154054&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=154054&action=review


Please submit Mac disabling of GraphicsSurface separately

> Source/WebCore/ChangeLog:9
> +	   Disable CopyToTexture feature for GraphicsSurface on Mac.
> +	   While this is actually working, it is currently used for Tiles
> +	   that are single buffered, and therefore requires a call to glFlush.
> +	   This call blocks the GPU for about 40ms which would make smooth
animations impossible.

This needs to be a different patch.


More information about the webkit-reviews mailing list