[webkit-reviews] review granted: [Bug 90381] [JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits. : [Attachment 154069] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 08:34:14 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 90381: [JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray()
using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Attachment 154069: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=154069&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=154069&action=review


OK

> Source/WebCore/bindings/js/JSDOMBinding.h:394
> +	   if (exec->hadException())
>	       return Vector<T>();

This check is not needed.


More information about the webkit-reviews mailing list