[webkit-reviews] review granted: [Bug 84286] Tables with just border-style set on the cells do not get a grid : [Attachment 153336] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 84286: Tables with just border-style set on the cells do not get a grid
https://bugs.webkit.org/show_bug.cgi?id=84286

Attachment 153336: Patch
https://bugs.webkit.org/attachment.cgi?id=153336&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153336&action=review


> Source/WebCore/rendering/RenderTreeAsText.cpp:318
> +	       BorderValue prevBorder = o.style()->borderTop();

To be frank, our text border dumping is inadequate as it would dump several
border configurations in the exact same way. Your change is definitely going in
the right direction of dumping more rather than less so you can keep this
change or just say that it should go in a list of stuff we will want to change
during a let-s-break-the-baselines hackathlon.