[webkit-reviews] review granted: [Bug 91442] nrwt: move the bulk of the "expected" output to printing.py : [Attachment 152640] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted  review:
Bug 91442: nrwt: move the bulk of the "expected" output to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91442

Attachment 152640: Patch
https://bugs.webkit.org/attachment.cgi?id=152640&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152640&action=review


>>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:421
>>> +	     self._printer._print_expected(tests_run_msg)
>> 
>> Calling a private method here. This should probably be print_expected and
print_expected below should be something like...print_expected_details or
something.
> 
> That gets fixed in https://bugs.webkit.org/show_bug.cgi?id=91447 , where
these messages turn into _log.debug(). Is it okay to leave this as-is for the
moment, or should I merge the other patch into this one, or would you prefer I
rename the methods as you suggest?

I see. Given that I've already r+'ed the other patch, I think it's fine. :)