[webkit-reviews] review granted: [Bug 91262] TOUCH_ADJUSTMENT is too aggressive when snapping to large elements. : [Attachment 152786] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Kevin Ellis
<kevers at chromium.org>'s request for review:
Bug 91262: TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Attachment 152786: Patch
https://bugs.webkit.org/attachment.cgi?id=152786&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152786&action=review


> Source/WebCore/page/TouchAdjustment.cpp:286
> +    float cx = 0.25*(p1.x() + p2.x() + p3.x() + p4.x());
> +    float cy = 0.25*(p1.y() + p2.y() + p3.y() + p4.y());

space * scpace

> Source/WebCore/page/TouchAdjustment.cpp:290
> +    FloatSize v = center - touchPoint;
> +    float d = v.diagonalLength();

v and d are not the webkit style for var names.

> Source/WebCore/page/TouchAdjustment.cpp:295
> +    float r = sqrt(dx*dx + dy*dy);

ditto + spaces