[webkit-reviews] review granted: [Bug 91447] nrwt: clean up logging when we're only running one chunk of the tests : [Attachment 152647] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 91447: nrwt: clean up logging when we're only running one chunk of the
tests
https://bugs.webkit.org/show_bug.cgi?id=91447

Attachment 152647: Patch
https://bugs.webkit.org/attachment.cgi?id=152647&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152647&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-431
> -	   tests_run_filename = self._filesystem.join(self._results_directory,
"tests_run.txt")

The valgrind layout tests bots used to use this IIRC in order to know which
chunk to run next. I suppose we can get rid of it for now since noone seems to
be using it. I suppose it's silly for this to be in RWT. The bot itself should
just read the stdio log and maintain this information itself if it needs it.