[webkit-reviews] review denied: [Bug 91442] nrwt: move the bulk of the "expected" output to printing.py : [Attachment 152640] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 17 13:29:47 PDT 2012
Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 91442: nrwt: move the bulk of the "expected" output to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91442
Attachment 152640: Patch
https://bugs.webkit.org/attachment.cgi?id=152640&action=review
------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152640&action=review
> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:421
> + self._printer._print_expected(tests_run_msg)
Calling a private method here. This should probably be print_expected and
print_expected below should be something like...print_expected_details or
something.
More information about the webkit-reviews
mailing list