[webkit-reviews] review granted: [Bug 91465] nrwt: move per-test result output into printing.py : [Attachment 152797] remove unused branch in update_summary_with_result()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 13:26:52 PDT 2012


Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 91465: nrwt: move per-test result output into printing.py
https://bugs.webkit.org/show_bug.cgi?id=91465

Attachment 152797: remove unused branch in update_summary_with_result()
https://bugs.webkit.org/attachment.cgi?id=152797&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152797&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-981
> -	   if result.type == test_expectations.SKIP:

Maybe mention in the ChangeLog why it's safe to remove this?


More information about the webkit-reviews mailing list