[webkit-reviews] review granted: [Bug 91129] NRWT doesn't print exceptions : [Attachment 152129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 09:29:50 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 91129: NRWT doesn't print exceptions
https://bugs.webkit.org/show_bug.cgi?id=91129

Attachment 152129: Patch
https://bugs.webkit.org/attachment.cgi?id=152129&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review


> Tools/Scripts/webkitpy/common/message_pool.py:284
> +	       _log.error("%s: %s('%s') raised:" % (
> +		       self.name, exception_value.__class__.__name__,
str(exception_value)))

Nit: I think this would be easier to read on one long line.


More information about the webkit-reviews mailing list