[webkit-reviews] review granted: [Bug 91170] webkitpy: make worker.start() and worker.stop() optional in the messagepool : [Attachment 152109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 09:31:23 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 91170: webkitpy: make worker.start() and worker.stop() optional in the
messagepool
https://bugs.webkit.org/show_bug.cgi?id=91170

Attachment 152109: Patch
https://bugs.webkit.org/attachment.cgi?id=152109&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review


> Tools/Scripts/webkitpy/common/message_pool.py:212
> +	       if hasattr(self._worker, 'stop'):

Does "if self.worker.stop" throw an undefined error or something?


More information about the webkit-reviews mailing list