[webkit-reviews] review denied: [Bug 90982] LLInt: Add op_get_by_id_proto : [Attachment 151743] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 11 11:53:25 PDT 2012


Filip Pizlo <fpizlo at apple.com> has denied Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 90982: LLInt: Add op_get_by_id_proto
https://bugs.webkit.org/show_bug.cgi?id=90982

Attachment 151743: Patch
https://bugs.webkit.org/attachment.cgi?id=151743&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151743&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2050
> +		   ASSERT(Heap::isMarked(curInstruction[5].u.structure.get()));


I believe this assertion is wrong.  See my previous comment.


More information about the webkit-reviews mailing list