[webkit-reviews] review denied: [Bug 90911] [BlackBerry] Implement Date/Time picker : [Attachment 151739] updated patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Crystal Zhang <haizhang at rim.com>'s
request for review:
Bug 90911: [BlackBerry] Implement Date/Time picker
https://bugs.webkit.org/show_bug.cgi?id=90911

Attachment 151739: updated patch
https://bugs.webkit.org/attachment.cgi?id=151739&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=151739&action=review


Looks good, found some small stuff.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:22
> +#include "IntSize.h"

You can use forward reference.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:25
> +#include "WebString.h"

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h:55
> +    HTMLInputElement* m_element;

Can you recheck the private situation again? I think at least the member vars
can be made private.