[webkit-reviews] review granted: [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent : [Attachment 150804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 08:41:39 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90264: Web Inspector: added low-level instrumentation support for
TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264

Attachment 150804: Patch
https://bugs.webkit.org/attachment.cgi?id=150804&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150804&action=review


> Source/WebCore/inspector/InspectorTimelineAgent.cpp:513
> +    , m_lowLevelEventsEnabledStackMark(0)

I would rename lowLevel to orphan for consistency. Otherwise looks good.

> Source/WebCore/inspector/InspectorTimelineAgent.h:202
> +    unsigned int m_lowLevelEventsEnabledStackMark;

just "unsigned"


More information about the webkit-reviews mailing list