[webkit-reviews] review denied: [Bug 90361] Web Inspector: Make DirectoryContentView sortable : [Attachment 150371] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 90361: Web Inspector: Make DirectoryContentView sortable
https://bugs.webkit.org/show_bug.cgi?id=90361

Attachment 150371: Patch
https://bugs.webkit.org/attachment.cgi?id=150371&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150371&action=review


Please make sure directories are correctly sorted.

> Source/WebCore/inspector/front-end/DirectoryContentView.js:139
> +	   if (x._entry.isDirectory)

This means directories order would be undefined. We should sort them by name
instead.

> Source/WebCore/inspector/front-end/DirectoryContentView.js:146
> +	   return (x._metadata ? x._metadata.size || 0 : 0) - (y._metadata ?
y._metadata.size || 0 : 0);

Is size defined for directories?

> Source/WebCore/inspector/front-end/DirectoryContentView.js:151
> +	   return (x._metadata ? x._metadata.modificationTime : 0) -
(y._metadata ? y._metadata.modificationTime : 0);

Is modification time defined for directories?