[webkit-reviews] review denied: [Bug 90293] Web Inspector: TextViewer's interaction with its panels should be event based : [Attachment 150210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 02:26:48 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 90293: Web Inspector: TextViewer's interaction with its panels should be
event based
https://bugs.webkit.org/show_bug.cgi?id=90293

Attachment 150210: Patch
https://bugs.webkit.org/attachment.cgi?id=150210&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150210&action=review


> Source/WebCore/inspector/front-end/TextViewer.js:975
> +	      
this._gutterPanel.dispatchEventToListeners(WebInspector.TextEditorChunkedPanel.
Events.DecorationsForLineSyncNeeded, this.startLine);

I would instead pass the delegate into the main panel.


More information about the webkit-reviews mailing list