[webkit-reviews] review granted: [Bug 76911] [GTK] WebKitWebView won't work in a GtkOffscreenWindow : [Attachment 124593] [GTK] WebKitWebView won't work in a GtkOffscreenWindow

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 76911: [GTK] WebKitWebView won't work in a GtkOffscreenWindow
https://bugs.webkit.org/show_bug.cgi?id=76911

Attachment 124593: [GTK] WebKitWebView won't work in a GtkOffscreenWindow
https://bugs.webkit.org/attachment.cgi?id=124593&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124593&action=review


> Source/WebKit/gtk/tests/testwebview.c:380
> +    loop = g_main_loop_new(NULL, TRUE);
> +
> +    GtkWidget *window = gtk_offscreen_window_new();
> +    GtkWidget *web_view = webkit_web_view_new();
> +
> +    gtk_container_add(GTK_CONTAINER(window), web_view);
> +    gtk_widget_show_all(window);
> +    g_signal_connect(web_view, "notify::load-status",
G_CALLBACK(idle_quit_loop_cb), NULL);
> +    webkit_web_view_load_uri(WEBKIT_WEB_VIEW(web_view), base_uri);
> +
> +    g_main_loop_run(loop);
> +

Seems that the main loop is leaking here? I'll fix when landing.