[webkit-reviews] review granted: [Bug 77250] webkit-perf.appspot.com should have an ability to merge tests : [Attachment 124388] Adds admin/merge-tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 30 14:23:06 PST 2012
Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 77250: webkit-perf.appspot.com should have an ability to merge tests
https://bugs.webkit.org/show_bug.cgi?id=77250
Attachment 124388: Adds admin/merge-tests
https://bugs.webkit.org/attachment.cgi?id=124388&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not sure what sort of review you're looking for here. Generally, we use
PEP8 style in our python (but without the 80 col limit). Names like
mergedResults don't match that style, but given that this is an addition to
code imported from Mozilla, we should probably match their style. Are you
planning to contribute these changes upstream?
In any case, I'm inclined to rubber-stamp these sorts of changes.
More information about the webkit-reviews
mailing list