[webkit-reviews] review granted: [Bug 77083] Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation : [Attachment 124086] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 77083: Speech Input: move MockSpeechInputClient into Chromium
DumpRenderTree implementation
https://bugs.webkit.org/show_bug.cgi?id=77083

Attachment 124086: Patch
https://bugs.webkit.org/attachment.cgi?id=124086&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124086&action=review


> Source/WebKit/chromium/public/WebSpeechInputResult.h:49
> +    WEBKIT_EXPORT void set(const WebSpeechInputResult& other);

nit: we normally call a function with this signature "assign".	maybe both
should be called assign, or maybe the first "set" should be broken out into
separate setters for each property (which is how most "property bag" classes
like this work).