[webkit-reviews] review granted: [Bug 77141] Simplify checking of whether we should rubberband horizontally : [Attachment 124180] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 77141: Simplify checking of whether we should rubberband horizontally
https://bugs.webkit.org/show_bug.cgi?id=77141

Attachment 124180: Patch
https://bugs.webkit.org/attachment.cgi?id=124180&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124180&action=review


> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:923
> -	   if (m_scrollableArea->isHorizontalScrollerPinnedToMinimumPosition()
&&
> -	       isScrollingLeftAndShouldNotRubberBand(wheelEvent,
m_scrollableArea))
> -	       return false;
> -
> -	   if (m_scrollableArea->isHorizontalScrollerPinnedToMaximumPosition()
&&
> -	       isScrollingRightAndShouldNotRubberBand(wheelEvent,
m_scrollableArea))
> +	   if (pinnedInDirection(-wheelEvent.deltaX(), 0) &&
> +	       !shouldRubberBandInHorizontalDirection(wheelEvent,
m_scrollableArea))

Do we still need
isHorizontalScrollerPinnedToMinimumPosition/isHorizontalScrollerPinnedToMaximum
Position?

pinnedInDirection is a confusing function. It takes two deltas, not a
direction! What does it all MEAN?