[webkit-reviews] review denied: [Bug 76913] Web Inspector: should be possible to open function declaration from script popover : [Attachment 123732] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 76913: Web Inspector: should be possible to open function declaration from
script popover
https://bugs.webkit.org/show_bug.cgi?id=76913

Attachment 123732: Patch
https://bugs.webkit.org/attachment.cgi?id=123732&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123732&action=review


> Source/WebCore/inspector/InjectedScriptHost.idl:48
> +	   [Custom] DOMString functionInferredName(in DOMObject object);

I would combine these into a single getter. I.e. extended location would
contain function name. As a result, the protocol would have

Runtime.getFunctionInfo returning location, name, displayName and inferredName
as separate optional properties.

> Source/WebCore/inspector/InjectedScriptSource.js:502
> +	       var name = object.name;

You should use object.displayName || object.name.