[webkit-reviews] review granted: [Bug 76843] Web Inspector: show memory counter graphs in timeline panel : [Attachment 123589] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 76843: Web Inspector: show memory counter graphs in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=76843

Attachment 123589: Patch
https://bugs.webkit.org/attachment.cgi?id=123589&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review


> Source/WebCore/inspector/Inspector.json:1897
> +		   "name": "setDomCountersEnabled",

setIncludeMemoryDetails ?

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
> +	   m_recordStack.last().record->setArray("memory",
domGroups.release());

This field seems to conflict with the heap info we are sending.

> Source/WebCore/inspector/front-end/TimelinePanel.js:155
> +WebInspector.MemoryStatistics.prototype = {

Could you extract this into a separate file?