[webkit-reviews] review granted: [Bug 76068] [Qt] Cleanup testfonts handling : [Attachment 122903] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 76068: [Qt] Cleanup testfonts handling
https://bugs.webkit.org/show_bug.cgi?id=76068

Attachment 122903: Patch
https://bugs.webkit.org/attachment.cgi?id=122903&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122903&action=review


> Tools/DumpRenderTree/qt/QtInitializeTestFonts.h:32
> +namespace WebCore {

I think WebKit would be a more appropriate namespace :)

> Tools/QtTestBrowser/main.cpp:245
> -#if defined(Q_WS_X11)
> +#if defined(HAVE_FONTCONFIG) && HAVE_FONTCONFIG

Do you need the #ifdefs here? It looks to me that initializeTestFonts() has
them in the function body already and the declaration is "fontconfig-free".