[webkit-reviews] review granted: [Bug 76735] [chromium] Tiled layers that get skipped once never get to draw again : [Attachment 123422] Resync-ed and resolved conflicts
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 23 12:52:06 PST 2012
James Robinson <jamesr at chromium.org> has granted Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 76735: [chromium] Tiled layers that get skipped once never get to draw
again
https://bugs.webkit.org/show_bug.cgi?id=76735
Attachment 123422: Resync-ed and resolved conflicts
https://bugs.webkit.org/attachment.cgi?id=123422&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123422&action=review
> Source/WebCore/ChangeLog:8
> + with the layer for the remainign of its lifetime.
typo: remainign -> remainder
> Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:99
> +class FakeCCLayerTreeHostClient : public CCLayerTreeHostClient {
this is very nearly the same thing as FakeCCLayerTreeHostClient in
LayerChromiumTest.cpp. Could you unify them and put it in a shared location?
Seems like a quite handy thing to have for unit tests.
More information about the webkit-reviews
mailing list