[webkit-reviews] review granted: [Bug 73971] [Chromium] WebFrame should have an interface to invoke spellchecking in arbitrarily : [Attachment 119825] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 15:36:23 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 73971: [Chromium] WebFrame should have an interface to invoke spellchecking
in arbitrarily
https://bugs.webkit.org/show_bug.cgi?id=73971

Attachment 119825: Patch
https://bugs.webkit.org/attachment.cgi?id=119825&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119825&action=review


> Source/WebKit/chromium/src/WebFrameImpl.cpp:1306
> +    RefPtr<Range> rangeToCheck =
rangeOfContents(static_cast<PassRefPtr<Element> >(webElem).get());

nit: use the WebNode::unwrap helper function here.

  RefPtr<Range> rangeToCheck = rangeOfContents(webElem.unwrap<Element>.get());


More information about the webkit-reviews mailing list