[webkit-reviews] review granted: [Bug 76405] Hit ASSERTION FAILED: table()->collapseBorders() on techcrunch.com : [Attachment 122982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 15:35:47 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 76405: Hit ASSERTION FAILED: table()->collapseBorders() on techcrunch.com
https://bugs.webkit.org/show_bug.cgi?id=76405

Attachment 122982: Patch
https://bugs.webkit.org/attachment.cgi?id=122982&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122982&action=review


> Source/WebCore/rendering/RenderTable.cpp:451
> +    for (RenderObject* o = firstChild(); o; o = o->nextSibling()) {
> +	   if (!o->isTableSection())

|section| would be a better name for |o|.

> Source/WebCore/rendering/RenderTable.cpp:459
> +		  
toRenderTableCell(cell)->collectBorderValues(m_collapsedBorders);

Would be nice to add an ASSERT here that cell->table() == this (we never want
to collect borders from any other table).


More information about the webkit-reviews mailing list